| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jul 2018 12:12:18 +0200
From: Karol Herbst <kherbst@...hat.com>
To: Lukas Wunner <lukas@...ner.de>
Cc: Lyude Paul <lyude@...hat.com>, David Airlie <airlied@...ux.ie>,
nouveau <nouveau@...ts.freedesktop.org>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
LKML <linux-kernel@...r.kernel.org>,
dri-devel <dri-devel@...ts.freedesktop.org>,
Ben Skeggs <bskeggs@...hat.com>,
Ville Syrjälä <ville.syrjala@...ux.intel.com>
Subject: Re: [Nouveau] [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs
Reviewed-by: Karol Herbst <karolherbst@...il.com>
On Tue, Jul 17, 2018 at 9:21 AM, Lukas Wunner <lukas@...ner.de> wrote:
> On Mon, Jul 16, 2018 at 07:59:26PM -0400, Lyude Paul wrote:
>> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
>> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
>> @@ -2012,10 +2012,18 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev)
>> return &atom->state;
>> }
>>
>> +static void
>> +nouveau_output_poll_changed(struct drm_device *dev)
>> +{
>> + pm_runtime_get_sync(dev->dev);
>> + drm_fb_helper_hotplug_event(dev->fb_helper);
>> + pm_runtime_put_autosuspend(dev->dev);
>> +}
>> +
>> static const struct drm_mode_config_funcs
>> nv50_disp_func = {
>> .fb_create = nouveau_user_framebuffer_create,
>> - .output_poll_changed = drm_fb_helper_output_poll_changed,
>> + .output_poll_changed = nouveau_output_poll_changed,
>
> It might make sense to provide a generic DRM helper for this.
> Same for patch 3 in this series.
>
> Thanks,
>
> Lukas
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
Powered by blists - more mailing lists