linux-kernel - Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Jul 2018 05:48:18 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Serge Semin <fancer.lancer@...il.com>
Cc:     Christoph Hellwig <hch@...radead.org>, ralf@...ux-mips.org,
        paul.burton@...s.com, jhogan@...nel.org, okaya@...eaurora.org,
        chenhc@...ote.com, Sergey.Semin@...latforms.ru,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated()
 method

On Wed, Jul 11, 2018 at 04:52:10PM +0300, Serge Semin wrote:
> Hello Christoph,
> 
> On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig <hch@...radead.org> wrote:
> > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow
> > > + * requests a cachable mapping with CWB attribute enabled.
> > >   */
> > >  #define ioremap_cacheable_cow(offset, size)				\
> > >  	__ioremap_mode((offset), (size), _CACHE_CACHABLE_COW)
> > 
> > This isn't actually used anywhere in the kernel tree.  Please remove it
> > as well.
> 
> I don't really know whether it is necessary at this point. We discarded the 
> ioremap_uncached_accelerated() method, since the obvious alternative is now
> available: ioremap_wc(). While ioremap_cacheable_cow() hasn't got one.
> So if it was up to me, I'd leave it here. Anyway if the subsystem maintainers
> think otherwise, I won't refuse to submit a patch with this method removal.

The function is entirely unused in the kernel tree, please remove it.