linux-kernel - Re: [PATCH 6/6] RFC: USB: storage: move symbols into USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jul 2018 11:04:09 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Martijn Coenen <maco@...roid.com>
cc:     Kernel development list <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Oliver Neukum <oneukum@...e.com>,
        USB list <linux-usb@...r.kernel.org>,
        USB Storage list <usb-storage@...ts.one-eyed-alien.net>
Subject: Re: [PATCH 6/6] RFC: USB: storage: move symbols into USB_STORAGE
 namespace.

On Mon, 16 Jul 2018, Martijn Coenen wrote:

> Modules using these symbols must now import this namesapce explicitly.

Spelling error ("namesapce").

> 
> Signed-off-by: Martijn Coenen <maco@...roid.com>
> ---
>  drivers/usb/storage/alauda.c        |  1 +
>  drivers/usb/storage/cypress_atacb.c |  1 +
>  drivers/usb/storage/datafab.c       |  1 +
>  drivers/usb/storage/ene_ub6250.c    |  1 +
>  drivers/usb/storage/freecom.c       |  1 +
>  drivers/usb/storage/isd200.c        |  1 +
>  drivers/usb/storage/jumpshot.c      |  1 +
>  drivers/usb/storage/karma.c         |  1 +
>  drivers/usb/storage/onetouch.c      |  1 +
>  drivers/usb/storage/realtek_cr.c    |  1 +
>  drivers/usb/storage/sddr09.c        |  1 +
>  drivers/usb/storage/sddr55.c        |  1 +
>  drivers/usb/storage/shuttle_usbat.c |  1 +
>  drivers/usb/storage/uas.c           |  1 +
>  drivers/usb/storage/usb.c           | 20 ++++++++++----------
>  15 files changed, 24 insertions(+), 10 deletions(-)

This patch misses the various EXPORT_SYMBOL_GPL lines in debug.c,
protocol.c, scsiglue.c, and transport.c.  They should also be
considered part of the USB_STORAGE namespace.

Alan Stern