linux-kernel - Re: [resend PATCH v4 5/5] drm: mediatek: Omit warning on probe defers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 11:04:17 +0800
From:   Sean Wang <sean.wang@...iatek.com>
To:     <matthias.bgg@...nel.org>
CC:     <ulrich.hecht+renesas@...il.com>,
        <laurent.pinchart@...asonboard.com>, <ck.hu@...iatek.com>,
        <p.zabel@...gutronix.de>, <airlied@...ux.ie>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <mturquette@...libre.com>,
        <sboyd@...eaurora.org>, <lee.jones@...aro.org>,
        <davem@...emloft.net>, <gregkh@...uxfoundation.org>,
        <mchehab@...nel.org>, <rdunlap@...radead.org>,
        <pi-cheng.chen@...aro.org>, <linux-clk@...r.kernel.org>,
        <linux@...linux.org.uk>, <matthias.bgg@...il.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [resend PATCH v4 5/5] drm: mediatek: Omit warning on probe
 defers

On Wed, 2018-07-18 at 00:03 +0200, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <mbrugger@...e.com>
> 
> It can happen that the clock drivers wasn't probed before the
> ddp driver gets invoked. The driver used to omit a warning
> that the driver failed to get the clocks. Omit this error on
> the defered probe path.
> 

so if we list drm device as a child device of mmsys we don't need the
patch, and that make more sense.

> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> Acked-by: CK Hu <ck.hu@...iatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index bafc5c77c4fb..6b399348a2dc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -374,7 +374,8 @@ static int mtk_ddp_probe(struct platform_device *pdev)
>  
>  	ddp->clk = devm_clk_get(dev, NULL);
>  	if (IS_ERR(ddp->clk)) {
> -		dev_err(dev, "Failed to get clock\n");
> +		if (PTR_ERR(ddp->clk) != -EPROBE_DEFER)
> +			dev_err(dev, "Failed to get clock\n");
>  		return PTR_ERR(ddp->clk);
>  	}
>