linux-kernel - Re: [PATCH net-next] net/mlx5: fix an unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jul 2018 17:42:25 -0700
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Ilya Lesokhin <ilyal@...lanox.com>,
        Boris Pismenny <borisp@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: fix an unused-function warning

On Tue, Jul 17, 2018 at 6:49 AM, Arnd Bergmann <arnd@...db.de> wrote:
> These dummy helpers are all intended to be inline functions,
> but one of them by accident came without the 'inline' keyword,
> causing a harmless warning:
>
> In file included from drivers/net/ethernet/mellanox/mlx5/core/main.c:63:
> drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h:79:1: error: 'mlx5_accel_tls_add_flow' defined but not used [-Werror=unused-function]
>  mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
>
> Fixes: ab412e1dd7db ("net/mlx5: Accel, add TLS rx offload routines")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Saeed Mahameed <saeedm@...lanox.com>

Dave, you can take this one to net-next.

Thanks!

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h b/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
> index 2228c1083528..def4093ebfae 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
> @@ -75,7 +75,7 @@ void mlx5_accel_tls_cleanup(struct mlx5_core_dev *mdev);
>
>  #else
>
> -static int
> +static inline int
>  mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
>                         struct tls_crypto_info *crypto_info,
>                         u32 start_offload_tcp_sn, u32 *p_swid,
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html