linux-kernel - Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 11:57:52 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Anand Moon <linux.amoon@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

On 18 July 2018 at 11:34, Anand Moon <linux.amoon@...il.com> wrote:
> Add missing GIC interrupts property for pwm nodes.
>
> Signed-off-by: Anand Moon <linux.amoon@...il.com>
> ---
>  arch/arm/boot/dts/exynos5.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index 5d2f0a0..9406108 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -169,6 +169,11 @@
>                 pwm: pwm@...d0000 {
>                         compatible = "samsung,exynos4210-pwm";
>                         reg = <0x12DD0000 0x100>;
> +                       interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
> +                                  <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,

Indentation here looks weird - spaces used after tabs but not aligned
with first entry. Please indent it properly and align it.

Best regards,
Krzysztof

> +                                  <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
> +                                  <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> +                                  <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
>                         samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>                         #pwm-cells = <3>;
>                 };
> --
> 2.7.4
>