linux-kernel - Re: [PATCH 1/1] Preventive fix in sound module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 12:16:29 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Srikanth K H" <srikanth.h@...sung.com>
Cc:     <alsa-devel@...a-project.org>, <keescook@...omium.org>,
        <ben.hutchings@...ethink.co.uk>, <perex@...ex.cz>,
        <elfring@...rs.sourceforge.net>, <linux-kernel@...r.kernel.org>,
        <viro@...iv.linux.org.uk>, <cpgs@...sung.com>
Subject: Re: [PATCH 1/1] Preventive fix in sound module

On Wed, 18 Jul 2018 12:07:48 +0200,
Srikanth K H wrote:
> 
> Signed-off-by: Srikanth K H <srikanth.h@...sung.com>

What does this fix, and above all, why is this needed?


thanks,

Takashi

> ---
>  sound/core/timer.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/timer.c b/sound/core/timer.c
> index b6f076bb..c7be4f1 100644
> --- a/sound/core/timer.c
> +++ b/sound/core/timer.c
> @@ -1192,10 +1192,12 @@ static void snd_timer_proc_read(struct snd_info_entry *entry,
>  			break;
>  		case SNDRV_TIMER_CLASS_CARD:
>  			snd_iprintf(buffer, "C%i-%i: ",
> -				    timer->card->number, timer->tmr_device);
> +					timer->card ? timer->card->number : -1,
> +					timer->tmr_device);
>  			break;
>  		case SNDRV_TIMER_CLASS_PCM:
> -			snd_iprintf(buffer, "P%i-%i-%i: ", timer->card->number,
> +			snd_iprintf(buffer, "P%i-%i-%i: ",
> +					timer->card ? timer->card->number : -1,
>  				    timer->tmr_device, timer->tmr_subdevice);
>  			break;
>  		default:
> -- 
> 1.9.1
> 
>