linux-kernel - Re: [alsa-devel] [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 17:39:11 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Jerome Brunet <jbrunet@...libre.com>, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, Kevin Hilman <khilman@...libre.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, Carlo Caione <carlo@...one.org>,
        linux-amlogic@...ts.infradead.org
Subject: Re: [alsa-devel] [PATCH RESEND 02/15] ASoC: meson: add axg fifo        base driver

On Wed, 18 Jul 2018 13:50:54 +0200,
Mark Brown wrote:
> 
> On Tue, Jul 17, 2018 at 05:42:51PM +0200, Jerome Brunet wrote:
> 
> > +	return !status ? IRQ_NONE : IRQ_HANDLED;
> 
> Please just write normal conditional statements, it makes things a lot
> easier to read (the ! isn't helping either here).

... and there is the standard IRQ_RETVAL() macro for this purpose.


Takashi