linux-kernel - Re: [PATCH 1/7] drivers: qcom: rpmh-rsc: fix the loop index check in get_req_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Jul 2018 13:45:44 +0530
From:   Raju P L S S S N <rplsssn@...eaurora.org>
To:     andy.gross@...aro.org, david.brown@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org
Cc:     rnayak@...eaurora.org, bjorn.andersson@...aro.org,
        linux-kernel@...r.kernel.org, sboyd@...nel.org,
        evgreen@...omium.org, dianders@...omium.org, mka@...omium.org,
        ilina@...eaurora.org
Subject: Re: [PATCH 1/7] drivers: qcom: rpmh-rsc: fix the loop index check in
 get_req_from_tcs

Hi all,

This is an independent patch and not part of patch set. There was some 
issue while sending the patch using git send-email. Please ignore 1/7 in 
the mail subject. Sorry for multiple mails.

Thanks,
Raju.

On 7/19/2018 12:43 PM, Raju P L S S S N wrote:
> From: "Raju P.L.S.S.S.N" <rplsssn@...eaurora.org>
> 
> get_req_from_tcs introduced in patch[1] returns tcs_request from
> tcs_group. The size of tcs (of type - tcs_group) array in rsc_drv is
> TCS_TYPE_NR. So the loop index needs to be iterated up to TCS_TYPE_NR only.
> 
> [1] https://patchwork.kernel.org/patch/10477547/
> 
> Signed-off-by: Raju P.L.S.S.S.N <rplsssn@...eaurora.org>
> ---
>   drivers/soc/qcom/rpmh-rsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index fefda0f..33fe9f9 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -190,7 +190,7 @@ static const struct tcs_request *get_req_from_tcs(struct rsc_drv *drv,
>   	struct tcs_group *tcs;
>   	int i;
>   
> -	for (i = 0; i < drv->num_tcs; i++) {
> +	for (i = 0; i < TCS_TYPE_NR; i++) {
>   		tcs = &drv->tcs[i];
>   		if (tcs->mask & BIT(tcs_id))
>   			return tcs->req[tcs_id - tcs->offset];
>