linux-kernel - Re: [PATCH 2/3] dt-bindings: arm: syna: add support for the AS370 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jul 2018 09:15:29 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 2/3] dt-bindings: arm: syna: add support for the AS370 SoC

On Fri, Jul 13, 2018 at 05:24:57PM +0800, Jisheng Zhang wrote:
> The AS370 SoC is a new derivative of the berlin family. The only
> difference is the SoC isn't named as berlin*.

So is it a derivative or just rebranded?

> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> ---
>  Documentation/devicetree/bindings/arm/syna.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/syna.txt b/Documentation/devicetree/bindings/arm/syna.txt
> index 3bab18409b7a..3ba1d7b5ee74 100644
> --- a/Documentation/devicetree/bindings/arm/syna.txt
> +++ b/Documentation/devicetree/bindings/arm/syna.txt
> @@ -1,4 +1,4 @@
> -Marvell Berlin SoC Family Device Tree Bindings
> +Synaptics SoC Device Tree Bindings

Perhaps some note about what has happened here. Otherwise it looks 
strange having "Marvell Berlin" in the document when the title says 
Synaptics SoC.

>  ---------------------------------------------------------------
>  
>  Work in progress statement:
> @@ -13,6 +13,10 @@ stable binding/ABI.
>  
>  ---------------------------------------------------------------
>  
> +Boards with the Synaptics AS370 SoC shall have the following properties:
> +  Required root node property:
> +    compatible: "syna,as370"
> +
>  Boards with a SoC of the Marvell Berlin family, e.g. Armada 1500
>  shall have the following properties:
>  
> -- 
> 2.18.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html