linux-kernel - Re: [PATCH 1/2] ARM: dts: tegra20: restore address order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jul 2018 10:38:20 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Marcel Ziswiler <marcel@...wiler.com>
Cc:     devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-tegra-owner@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: tegra20: restore address order

On 20.07.2018 18:34, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Commit 6c468f109884 ("ARM: dts: tegra: add Tegra20 NAND flash
> controller node") introduced the nand-controller node. However, it got
> added at the wrong spot not honoring the address order. Fix this.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

Reviewed-by: Stefan Agner <stefan@...er.ch>

> 
> ---
> 
>  arch/arm/boot/dts/tegra20.dtsi | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 979f38293fe5..a22c6a8f8f83 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -419,19 +419,6 @@
>  		status = "disabled";
>  	};
>  
> -	gmi@...09000 {
> -		compatible = "nvidia,tegra20-gmi";
> -		reg = <0x70009000 0x1000>;
> -		#address-cells = <2>;
> -		#size-cells = <1>;
> -		ranges = <0 0 0xd0000000 0xfffffff>;
> -		clocks = <&tegra_car TEGRA20_CLK_NOR>;
> -		clock-names = "gmi";
> -		resets = <&tegra_car 42>;
> -		reset-names = "gmi";
> -		status = "disabled";
> -	};
> -
>  	nand-controller@...08000 {
>  		compatible = "nvidia,tegra20-nand";
>  		reg = <0x70008000 0x100>;
> @@ -447,6 +434,19 @@
>  		status = "disabled";
>  	};
>  
> +	gmi@...09000 {
> +		compatible = "nvidia,tegra20-gmi";
> +		reg = <0x70009000 0x1000>;
> +		#address-cells = <2>;
> +		#size-cells = <1>;
> +		ranges = <0 0 0xd0000000 0xfffffff>;
> +		clocks = <&tegra_car TEGRA20_CLK_NOR>;
> +		clock-names = "gmi";
> +		resets = <&tegra_car 42>;
> +		reset-names = "gmi";
> +		status = "disabled";
> +	};
> +
>  	pwm: pwm@...0a000 {
>  		compatible = "nvidia,tegra20-pwm";
>  		reg = <0x7000a000 0x100>;