linux-kernel - Re: [PATCH 1/2] mmc: tmio: rename files and CONFIG options to have the same prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jul 2018 11:28:04 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Linux MMC List <linux-mmc@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mmc: tmio: rename files and CONFIG options to have
 the same prefix

Hi Yamada-san,

On Thu, Jul 26, 2018 at 11:15 AM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> 2018-07-26 17:25 GMT+09:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
> > On Thu, Jul 26, 2018 at 5:33 AM Masahiro Yamada
> > <yamada.masahiro@...ionext.com> wrote:
> >> This commit renames files as follows:
> >>
> >>   tmio_mmc_core.c              -> tmio_mmc.c
> >>   tmio_mmc.c                   -> tmio_mmc_original.c
> >>   renesas_sdhi_core.c          -> tmio_mmc_sdhi.c
> >>   renesas_sdhi.h               -> tmio_mmc_sdhi.h
> >>   renesas_sdhi_internal_dmac.c -> tmio_mmc_sdhi_internal_dmac.c
> >>   renesas_sdhi_sys_dmac.c      -> tmio_mmc_sdhi_sys_dmac.c
> >
> > I have mixed feelings about the last two renames, especially about the last
> > one: SYS-DMAC is very Renesas-specific, as it's a separate IP block in
> > Renesas SoCs.

> > 2. Are there other SoCs using an external DMAC?
>
> Yes.  Some old SoCs in UniPhier SoC family rely on
> the external DMAC, like renesas_sdhi_sys_dmac.c
>
> >    Is the interface to the external DMAC similar?
> >    If yes, perhaps it should be renamed to tmio_mmc_sdhi_external_dmac.c?
>
> "sdhi" is already Renesas-specific name, isn't it?

Right, I'm mixing up SDHI and SDHC.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds