linux-kernel - Re: include architecture Kconfig files from top-level Kconfig v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Jul 2018 09:50:45 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Richard Weinberger <richard@....at>,
        Ley Foon Tan <lftan@...era.com>,
        Michal Simek <monstr@...str.eu>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        linux-um@...ts.infradead.org, linux-arch@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: include architecture Kconfig files from top-level Kconfig v3

2018-07-27 16:48 GMT+09:00 Christoph Hellwig <hch@....de>:
> On Fri, Jul 27, 2018 at 10:32:19AM +0900, Masahiro Yamada wrote:
>> This will just add a new unmet dependency warning.
>> CONFIG_PREEMPT_COUNT will be still selected.
>
> True.  I guess we simply need to prohibit CONFIG_DEBUG_ATOMIC_SLEEP
> explicitly if PREEMPT_COUNT isn't supported.  E.g something like this:
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 26d3ff7e3cf4..373ce9fecd7e 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1195,6 +1195,7 @@ config DEBUG_ATOMIC_SLEEP
>         bool "Sleep inside atomic section checking"
>         select PREEMPT_COUNT
>         depends on DEBUG_KERNEL
> +       depends on !ARCH_NO_PREEMPT
>         help
>           If you say Y here, various routines which may sleep will become very
>           noisy if they are called inside atomic sections: when a spinlock is


I will fold this into 07/10.


I see another 'select PREEMPT_COUNT' in
drivers/gpu/drm/i915/Kconfig.debug
but DRM_I915 depends on X86, so this is not
a real problem.



-- 
Best Regards
Masahiro Yamada