linux-kernel - Re: [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jul 2018 11:11:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct
 cmpk_txfb_t - Style

On Sun, Jul 29, 2018 at 10:07:33PM +0100, John Whitmore wrote:
> Remove the typedef of the structure cmpk_txfb_t. This clears the
> checkpatch issue with defining new types.
> 
> Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback
> removing the '_t' as the typedef has been removed.
> 
> These changes are purely coding style in nature and should have no
> impact on runtime code execution.
> 
> Signed-off-by: John Whitmore <johnfwhitmore@...il.com>
> ---
>  drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8 ++++----
>  drivers/staging/rtl8192u/r819xU_cmdpkt.h | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> index 3140b3413f91..630cf612f265 100644
> --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> @@ -66,7 +66,7 @@ rt_status SendTxCommandPacket(struct net_device *dev, void *pData, u32 DataLen)
>   * Overview:
>   *
>   * Input:       PADAPTER	pAdapter
> - *              CMPK_TXFB_T	*psTx_FB
> + *              STRUCT CMD_PKT_TX_FEEDBACK	*psTx_FB

nit, this should all be in lowercase now right?

Anyway, these function comments need to all go anyway, they are horrid :)

Something for future patches, look at the ones for the gasket driver
sent yesterday as an example of what to do.

thanks,

greg k-h