| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jul 2018 14:17:02 +0800 (CST)
From: <wang.yi59@....com.cn>
To: <rostedt@...dmis.org>
Cc: <tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
<x86@...nel.org>, <douly.fnst@...fujitsu.com>, <jgross@...e.com>,
<ville.syrjala@...ux.intel.com>, <len.brown@...el.com>,
<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
<jiang.biao2@....com.cn>, <zhong.weidong@....com.cn>,
<trivial@...nel.org>
Subject: Re: [PATCH] x86/apic: fix two slight indenting
Thanks a lot, Steven.
---
Best wishes
Yi Wang
Original Mail
Sender: StevenRostedt <rostedt@...dmis.org>
To: Wang Yi10129963;
CC: tglx@...utronix.de <tglx@...utronix.de>mingo@...hat.com <mingo@...hat.com>hpa@...or.com <hpa@...or.com>x86@...nel.org <x86@...nel.org>douly.fnst@...fujitsu.com <douly.fnst@...fujitsu.com>jgross@...e.com <jgross@...e.com>ville.syrjala@...ux.intel.com <ville.syrjala@...ux.intel.com>len.brown@...el.com <len.brown@...el.com>linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>gregkh@...uxfoundation.org <gregkh@...uxfoundation.org>Jiang Biao10062664;Zhong Weidong10001088;trivial@...nel.org <trivial@...nel.org>
Date: 2018/07/27 23:33
Subject: Re: [PATCH] x86/apic: fix two slight indenting
This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:
Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
-- Steve
On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <wang.yi59@....com.cn> wrote:
> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.
>
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> Reviewed-by: Jiang Biao <jiang.biao2@....com.cn>
> ---
> arch/x86/kernel/apic/apic.c | 2 +-
> arch/x86/kernel/apic/vector.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>
> if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
> pr_warning("APIC timer disabled due to verification failure\n");
> - return -1;
> + return -1;
> }
>
> return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
> pr_err("Managed startup irq %u, no vector available\n",
> irqd->irq);
> }
> - return ret;
> + return ret;
> }
>
> static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,
<div class="zcontentRow"><p style="font-size:12px;font-family:arial;">Thanks a lot, <span style="line-height: 21px;">Steven.</span></p><p style="font-size:12px;font-family:arial;"><br></p><div class="zMailSign" unonamech="汪翼10129963" unonameen="wang yi10129963"><p class="zMailSignTitle" unonamech="汪翼10129963" unonameen="wang yi10129963" style="display: none;"><label class="sign_nameUno"></label><span class="sign_arrow"></span></p><div class="zMailSignContent"><div><p>---</p><p>Best wishes</p><p>Yi Wang</p></div></div></div><div><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;" language-data="HistoryOrgTxt">Original Mail</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div><strong language-data="HistorySenderTxt">Sender: </strong><span class="zreadUserName">StevenRostedt <rostedt@...dmis.org></span></div><div><strong language-data="HistoryTOTxt">To: </strong><span class="zreadUserName" style="display: inline;">Wang Yi10129963;</span></div><div><strong language-data="HistoryCCTxt">CC: </strong><span class="zreadUserName" style="display: inline;">tglx@...utronix.de <tglx@...utronix.de></span><span class="zreadUserName" style="display: inline;">mingo@...hat.com <mingo@...hat.com></span><span class="zreadUserName" style="display: inline;">hpa@...or.com <hpa@...or.com></span><span class="zreadUserName" style="display: inline;">x86@...nel.org <x86@...nel.org></span><span class="zreadUserName" style="display: inline;">douly.fnst@...fujitsu.com <douly.fnst@...fujitsu.com></span><span class="zreadUserName" style="display: inline;">jgross@...e.com <jgross@...e.com></span><span class="zreadUserName" style="display: inline;">ville.syrjala@...ux.intel.com <ville.syrjala@...ux.intel.com></span><span class="zreadUserName" style="display: inline;">len.brown@...el.com <len.brown@...el.com></span><span class="zreadUserName" style="display: inline;">linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org></span><span class="zreadUserName" style="display: inline;">gregkh@...uxfoundation.org <gregkh@...uxfoundation.org></span><span class="zreadUserName" style="display: inline;">Jiang Biao10062664;</span><span class="zreadUserName" style="display: inline;">Zhong Weidong10001088;</span><span class="zreadUserName" style="display: inline;">trivial@...nel.org <trivial@...nel.org></span></div><div><strong language-data="HistoryDateTxt">Date: </strong><span class="">2018/07/27 23:33</span></div><div><strong language-data="HistorySubjectTxt">Subject: </strong><span class="zreadTitle"><strong>Re: [PATCH] x86/apic: fix two slight indenting</strong></span></div></div><div class="zhistoryContent"><div><br>This looks like it should go through the trivial tree. Although I'm not<br>the maintainer of this code, it looks reasonable to me, and I'll give<br>my:<br><br>Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org><br><br>-- Steve<br><br><br>On Fri, 27 Jul 2018 14:15:03 +0800<br>Yi Wang <wang.yi59@....com.cn> wrote:<br><br>> There are two inconsistent indenting in calibrate_APIC_clock()<br>> and activate_managed(). Remove the surplus TAB.<br>> <br>> Signed-off-by: Yi Wang <wang.yi59@....com.cn><br>> Reviewed-by: Jiang Biao <jiang.biao2@....com.cn><br>> ---<br>> arch/x86/kernel/apic/apic.c | 2 +-<br>> arch/x86/kernel/apic/vector.c | 2 +-<br>> 2 files changed, 2 insertions(+), 2 deletions(-)<br>> <br>> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c<br>> index 5071cc7..f222ebc 100644<br>> --- a/arch/x86/kernel/apic/apic.c<br>> +++ b/arch/x86/kernel/apic/apic.c<br>> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)<br>> <br>> if (levt->features & CLOCK_EVT_FEAT_DUMMY) {<br>> pr_warning("APIC timer disabled due to verification failure\n");<br>> - return -1;<br>> + return -1;<br>> }<br>> <br>> return 0;<br>> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c<br>> index b708f59..19e0b2f 100644<br>> --- a/arch/x86/kernel/apic/vector.c<br>> +++ b/arch/x86/kernel/apic/vector.c<br>> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)<br>> pr_err("Managed startup irq %u, no vector available\n",<br>> irqd->irq);<br>> }<br>> - return ret;<br>> + return ret;<br>> }<br>> <br>> static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,<br></div></div></div></div></div></div><p><br></p></div>
Powered by blists - more mailing lists