linux-kernel - Re: [PATCH v2] driver/scsi/pmcraid: Use pci_zalloc_consistent instead of pci_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Aug 2018 17:14:27 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     John Garry <john.garry@...wei.com>
CC:     <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] driver/scsi/pmcraid: Use pci_zalloc_consistent instead
 of pci_alloc_consistent+memset

On 2018/8/1 16:27, John Garry wrote:
> 在 2018/8/1 15:16, zhong jiang 写道:
>> Pci_zalloc_consistent is better than pci_alloc_consistent+memset,
>> and it make the code concise
>
> Aren't these APIs deprecated:
> https://lkml.org/lkml/2018/6/5/381
>
I miss that, Thanks

Thanks
zhong jiang
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>> drivers/scsi/pmcraid.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
>> index 4e86994..8a6facc 100644
>> --- a/drivers/scsi/pmcraid.c
>> +++ b/drivers/scsi/pmcraid.c
>> @@ -4736,11 +4736,9 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance)
>> buffer_size = HRRQ_ENTRY_SIZE * PMCRAID_MAX_CMD;
>> for (i = 0; i < pinstance->num_hrrq; i++) {
>> - pinstance->hrrq_start[i] =
>> - pci_alloc_consistent(
>> - pinstance->pdev,
>> - buffer_size,
>> - &(pinstance->hrrq_start_bus_addr[i]));
>> + pinstance->hrrq_start[i] = pci_zalloc_consistent(pinstance->pdev,
>> + buffer_size,
>> + &(pinstance->hrrq_start_bus_addr[i]));
>> if (!pinstance->hrrq_start[i]) {
>> pmcraid_err("pci_alloc failed for hrrq vector : %d\n",
>> @@ -4749,7 +4747,6 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance)
>> return -ENOMEM;
>> }
>> - memset(pinstance->hrrq_start[i], 0, buffer_size);
>> pinstance->hrrq_curr[i] = pinstance->hrrq_start[i];
>> pinstance->hrrq_end[i] =
>> pinstance->hrrq_start[i] + PMCRAID_MAX_CMD - 1;
>>
>
>
>
> .
>