linux-kernel - Re: [PATCH] driver/scsi/pmcraid: Use pci_zalloc_consistent instead of pci_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Aug 2018 13:07:48 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] driver/scsi/pmcraid: Use pci_zalloc_consistent instead of pci_alloc_consistent+memset

On Wed, Aug 1, 2018 at 10:08 AM, zhong jiang <zhongjiang@...wei.com> wrote:
> Pci_alloc_consistent+memset is better than pci_alloc_consistent+memset,
> and it make the code concise

It should use dma_*alloc_*() functions directly. PCI ones are not for
new code AFAIK.

>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/scsi/pmcraid.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 4e86994..8a6facc 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4736,11 +4736,9 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance)
>         buffer_size = HRRQ_ENTRY_SIZE * PMCRAID_MAX_CMD;
>
>         for (i = 0; i < pinstance->num_hrrq; i++) {
> -               pinstance->hrrq_start[i] =
> -                       pci_alloc_consistent(
> -                                       pinstance->pdev,
> -                                       buffer_size,
> -                                       &(pinstance->hrrq_start_bus_addr[i]));
> +               pinstance->hrrq_start[i] = pci_zalloc_consistent(pinstance->pdev,
> +                                                               buffer_size,
> +                                                               &(pinstance->hrrq_start_bus_addr[i]));
>
>                 if (!pinstance->hrrq_start[i]) {
>                         pmcraid_err("pci_alloc failed for hrrq vector : %d\n",
> @@ -4749,7 +4747,6 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance)
>                         return -ENOMEM;
>                 }
>
> -               memset(pinstance->hrrq_start[i], 0, buffer_size);
>                 pinstance->hrrq_curr[i] = pinstance->hrrq_start[i];
>                 pinstance->hrrq_end[i] =
>                         pinstance->hrrq_start[i] + PMCRAID_MAX_CMD - 1;
> --
> 1.7.12.4
>



-- 
With Best Regards,
Andy Shevchenko