linux-kernel - Re: [PATCH] drm/rockchip: Convert drm_atomic_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 01 Aug 2018 14:33:36 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     hjc@...k-chips.com, airlied@...ux.ie, ajitn.linux@...il.com,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume()

Hi Souptick,

Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder:
> convert drm_atomic_helper_suspend/resume() to use
> drm_mode_config_helper_suspend/resume().
> 
> With this conversion, rockchip_drm_fb_resume() and
> rockchip_drm_fb_suspend() will not be used anymore.
> Both of these functions can be removed.
> 
> Also, in struct rockchip_drm_private state will not be
> used anymore. So this can be removed forever.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> Signed-off-by: Ajit Negi <ajitn.linux@...il.com>

the patch itself looks great, just a simple bookkeeping question.

What role did Ajit play in creating the patch? If I remember correctly
it is meant to be
- 1st Signed-off: Patch-Author
- 2nd Signed-off: E-Mail sender + patch possibly patch changes
(optional of course if the same)

So was this meant to be a Reviewed-by from Ajit?


Thanks
Heiko