linux-kernel - Re: [PATCH 1/2] scsi:qla1280: remove unnessary same condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Aug 2018 03:22:36 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "zhongjiang@...wei.com" <zhongjiang@...wei.com>,
        "aacraid@...rosemi.com" <aacraid@...rosemi.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "john.garry@...wei.com" <john.garry@...wei.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] scsi:qla1280: remove unnessary same condition check

On Thu, 2018-08-02 at 10:45 +0800, zhong jiang wrote:
> doulbe test in a expression is redundant. so just remove one of
> them.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/scsi/qla1280.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index 390775d..8e6f156 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -1504,7 +1504,6 @@ static void qla1280_mailbox_timeout(struct timer_list *t)
>  	/* Issue SCSI reset, if we can't reset twice then bus is dead */
>  	for (bus = 0; bus < ha->ports; bus++) {
>  		if (!ha->bus_settings[bus].disable_scsi_reset &&
> -		    qla1280_bus_reset(ha, bus) &&
>  		    qla1280_bus_reset(ha, bus))
>  			ha->bus_settings[bus].scsi_bus_dead = 1;
>  	}

Same question here: does qla1280_bus_reset() have any side effects?

Bart.