linux-kernel - Re: [PATCH v2 1/2] net/9p: embed fcall in req to round down buffer allocs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Aug 2018 00:03:43 +0200
From:   Dominique Martinet <asmadeus@...ewreck.org>
To:     Greg Kurz <groug@...d.org>
Cc:     v9fs-developer@...ts.sourceforge.net,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dominique Martinet <dominique.martinet@....fr>,
        Matthew Wilcox <willy@...radead.org>,
        Jun Piao <piaojun@...wei.com>
Subject: Re: [PATCH v2 1/2] net/9p: embed fcall in req to round down buffer
 allocs

Greg Kurz wrote on Thu, Aug 02, 2018:
> > @@ -443,9 +444,9 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req)
> >  	 **/
> >  	if (unlikely(atomic_read(&rdma->excess_rc) > 0)) {
> >  		if ((atomic_sub_return(1, &rdma->excess_rc) >= 0)) {
> > -			/* Got one ! */
> > -			kfree(req->rc);
> > -			req->rc = NULL;
> > +			/* Got one! */
> > +			kfree(req->rc.sdata);
> 
> Shouldn't this be p9_fcall_fini(&req->rc) ?

Right, I failed at bookkeeping, I changed that in the next patch but it
should have been done now.
Will add p9_fcall_fini to headers/export in this patch instead of the
next

> The rest looks good, so, with that fixed, you can add:
> 
> Reviewed-by: Greg Kurz <groug@...d.org>

Thanks!

-- 
Dominique