linux-kernel - Re: [PATCH 17/46] dmaengine: stm32-mdma: use dmaenginem_async_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6826c0d6-5d44-631e-ff5e-d67e90a5a848@st.com>
Date:   Fri, 3 Aug 2018 10:10:31 +0200
From:   Pierre Yves MORDRET <pierre-yves.mordret@...com>
To:     Huang Shijie <sjhuang@...vatar.ai>, <vkoul@...nel.org>
CC:     <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dave.jiang@...el.com>, <radhey.shyam.pandey@...inx.com>,
        <appana.durga.rao@...inx.com>, <jmkrzyszt@...il.com>,
        <gomonovych@...il.com>, <peter.ujfalusi@...com>,
        <keescook@...omium.org>, <horms+renesas@...ge.net.au>,
        <geert+renesas@...der.be>, <shawnguo@...nel.org>,
        <baoyou.xie@...aro.org>, <michal.simek@...inx.com>,
        <baohua@...nel.org>, <ludovic.desroches@...rochip.com>,
        <linus.walleij@...aro.org>, <david.brown@...aro.org>
Subject: Re: [PATCH 17/46] dmaengine: stm32-mdma: use
 dmaenginem_async_device_register to simplify the code

Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>

On 08/03/2018 09:19 AM, Huang Shijie wrote:
> Use dmaenginem_async_device_register to simplify the code:
> 	remove dma_async_device_unregister.
> 
> Signed-off-by: Huang Shijie <sjhuang@...vatar.ai>
> ---
>  drivers/dma/stm32-mdma.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 06dd1725375e..390e4cae0e1a 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1656,7 +1656,7 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	ret = dma_async_device_register(dd);
> +	ret = dmaenginem_async_device_register(dd);
>  	if (ret)
>  		return ret;
>  
> @@ -1674,8 +1674,6 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_unregister:
> -	dma_async_device_unregister(dd);
> -
>  	return ret;
>  }
>  
>