lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Aug 2018 10:39:55 +0800 From: zhong jiang <zhongjiang@...wei.com> To: Joe Perches <joe@...ches.com> CC: <clm@...com>, <jbacik@...com>, <dsterba@...e.com>, <linux-btrfs@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err" On 2018/8/5 23:27, Joe Perches wrote: > On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote: >> The err is not used after initalization, So remove it and make >> the function to be void function. > [] >> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > [] >> @@ -4193,7 +4192,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, >> if (atomic_read(&delayed_refs->num_entries) == 0) { >> spin_unlock(&delayed_refs->lock); >> btrfs_info(fs_info, "delayed_refs has NO entry"); >> - return ret; > Think a little more about this please. > This is not a sensible removal. I am sorry for stupid mistake. I will repost. Thanks, zhong jiang >> } >> >> while ((node = rb_first(&delayed_refs->href_root)) != NULL) { > > . >
Powered by blists - more mailing lists