linux-kernel - Re: [PATCH] s390/qeth: use true and false for boolean values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Aug 2018 07:39:07 +0200
From:   Julian Wiedmann <jwi@...ux.ibm.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Ursula Braun <ubraun@...ux.ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/qeth: use true and false for boolean values

On 08/05/2018 02:59 AM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Queued up for net-next, thanks.

> ---
>  drivers/s390/net/qeth_l3_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 1833e75..7175086 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -117,9 +117,9 @@ static bool qeth_l3_is_addr_covered_by_ipato(struct qeth_card *card,
>  	int rc = 0;
>  
>  	if (!card->ipato.enabled)
> -		return 0;
> +		return false;
>  	if (addr->type != QETH_IP_TYPE_NORMAL)
> -		return 0;
> +		return false;
>  
>  	qeth_l3_convert_addr_to_bits((u8 *) &addr->u, addr_bits,
>  				  (addr->proto == QETH_PROT_IPV4)? 4:16);
>