linux-kernel - Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Aug 2018 23:16:54 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Ravi Chandra Sadineni <ravisadineni@...omium.org>,
        Ravi Chandra Sadineni <ravisadineni@...gle.com>,
        Todd Broch <tbroch@...gle.com>,
        lkml <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski
<m.szyprowski@...sung.com> wrote:
>
> Hi Ravi,
>
> On 2018-08-03 18:53, Ravi Chandra Sadineni wrote:
> > Understood. I am trying to reproduce this issue locally. Wanted to
> > know the version of the kernel so I can give a try. Marek, can you
> > please confirm the kernel version.
> >
>
> Yes, sorry for the missing context, I was in hurry writing the report and
> I wanted to send it before leaving the office. I'm testing mainline on Snow
> with exynos_defconfig.
>
> Suspend/resume is partially broken already with mainline, but if you disable
> CPUfreq support, it works fine on Linux v4.17.
>
> I've posted CPUfreq related fixes here if you are interested:
> https://patchwork.kernel.org/patch/10554607/
> https://patchwork.kernel.org/patch/10554603/
>
> The issue with cros_ec_keyb patch appears first on Linux v4.18-rc1, which is
> the first release with that patch.

Marek, this patch should only be in -next, I do not believe I sent it
to Linus just yet. If mainline is broken for you it can't be caused by
this patch.

> Linux -next from 20180803, which has a few
> more patches for cros_ec_keyb suffers from the same issue.

Just to confirm, if you revert only this patch from -next you get
suspend/resume back?

Thanks.

-- 
Dmitry