linux-kernel - Re: [PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 07 Aug 2018 22:13:47 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <groeck@...omium.org>,
        Nicolas Boichat <drinkcat@...omium.org>
Subject: Re: [PATCH v2] ASoC: rt5677: Fix initialization of
 rt5677_of_match.data

On Tue, 2018-08-07 at 10:19 -0700, Matthias Kaehlcke wrote:
> The driver expects to find the device id in rt5677_of_match.data,
> however
> it is currently assigned to rt5677_of_match.type. Fix this.
> 
> The problem was found with the help of clang:
>   sound/soc/codecs/rt5677.c:5010:36: warning: expression which
> evaluates to
>   zero treated as a null pointer constant of type 'const void *'
>   [-Wnon-literal-null-conversion]
>     { .compatible = "realtek,rt5677", RT5677 },
>                                       ^~~~~~
> 
> Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module
> sources")
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

While this is correct fix, it seems it was never used.

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
 
>  static const struct of_device_id rt5677_of_match[] = {
> -	{ .compatible = "realtek,rt5677", RT5677 },
> +	{ .compatible = "realtek,rt5677", .data = (const void *)RT5677
> },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, rt5677_of_match);

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy