[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 08 Aug 2018 09:57:50 -0400
From: Adam Jackson <ajax@...hat.com>
To: Gerd Hoffmann <kraxel@...hat.com>, dri-devel@...ts.freedesktop.org
Cc: David Airlie <airlied@...ux.ie>, Dave Airlie <airlied@...hat.com>,
open list <linux-kernel@...r.kernel.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v3] drm/cirrus: flip default from 24bpp to 16bpp
On Wed, 2018-08-08 at 13:13 +0200, Gerd Hoffmann wrote:
> The problem with 24bpp is that it is a rather unusual depth these days,
Nit: s/depth/bpp/ here. Depth 24 is very common, it's packing that into
three bytes per pixel that's unusual.
> cirrus is pretty much the only relevant device still using that, and it
> is a endless source of issues. Wayland doesn't support it at all. Bugs
> in Xorg keep showing up.
>
> Typically either 32bpp or 16bpp are used. Using 32bpp would limit the
> resolution to 800x600 due to hardware constrains. So lets go with 16bpp.
>
> Also use the default depth for the framebuffer console and
> mode_info->preferred_depth.
>
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
Reviewed-by: Adam Jackson <ajax@...hat.com>
- ajax
Powered by blists - more mailing lists