linux-kernel - Re: [PATCH v2] fs/btrfs: remove the unneeded variable "err" and change the function to be void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Aug 2018 22:11:07 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <dsterba@...e.cz>, <clm@...com>, <jbacik@...com>,
        <dsterba@...e.com>, <linux-btrfs@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] fs/btrfs: remove the unneeded variable "err" and change
 the function to be void function

On 2018/8/7 23:25, David Sterba wrote:
> On Mon, Aug 06, 2018 at 10:52:58AM +0800, zhong jiang wrote:
>> The err is not modified after initalization, So just remove it and make
>> the function to be void function.
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>> v1->v2:
>>  - Merge v1 series into a patch to void same changelog.
> Please do one patch per function. If the change follows the same logic,
> it's not a problem to use the same changelog, but the patch should be
> revieweable and not doing unrelated things.
>
> If the function prototype or return values is changed it's easier from
> the reviewer's perspective to focus on just one function and the
> surrounding code. Even if it looks straightforward to you to merge them
> together.
>
> When the return value changes from int -> void, it's necessary to check
> wheter any of the callees is not hiding a BUG_ON that should be really
> turned into proper error handling in the caller. In that case the return
> type should stay and error handling added.
>
> After a brief look I think all functions are safe here, but that's
> something that should be mentioned in the changelog. Please update the
> patches and resend. Thanks.
>
> .
>
I will repost the patches with detailed changlog. Thank you for explaination.

Thanks
zhong jiang