linux-kernel - Re: [RFC] RISC-V: Fix !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Aug 2018 11:31:08 -0700
From:   Atish Patra <atish.patra@....com>
To:     "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "palmer@...ive.com" <palmer@...ive.com>,
        "alankao@...estech.com" <alankao@...estech.com>,
        "sols@...ive.com" <sols@...ive.com>
Cc:     "peterz@...radead.org" <peterz@...radead.org>,
        "nickhu@...estech.com" <nickhu@...estech.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] RISC-V: Fix !CONFIG_SMP compilation error

On 8/6/18 4:17 PM, Atish Patra wrote:
> Enabling both CONFIG_PERF_EVENTS without !CONFIG_SMP
> generates following compilation error.
> 
> arch/riscv/include/asm/perf_event.h:80:2: error: expected
> specifier-qualifier-list before 'irqreturn_t'
> 
>    irqreturn_t (*handle_irq)(int irq_num, void *dev);
>    ^~~~~~~~~~~
> 
> Include interrupt.h in proper place to avoid compilation
> error.
> 
> Signed-off-by: Atish Patra <atish.patra@....com>
> ---
>   arch/riscv/include/asm/perf_event.h | 1 +
>   arch/riscv/kernel/perf_event.c      | 1 -
>   2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/perf_event.h b/arch/riscv/include/asm/perf_event.h
> index 0e638a0c..aefbfaa6 100644
> --- a/arch/riscv/include/asm/perf_event.h
> +++ b/arch/riscv/include/asm/perf_event.h
> @@ -10,6 +10,7 @@
>   
>   #include <linux/perf_event.h>
>   #include <linux/ptrace.h>
> +#include <linux/interrupt.h>
>   
>   #define RISCV_BASE_COUNTERS	2
>   
> diff --git a/arch/riscv/kernel/perf_event.c b/arch/riscv/kernel/perf_event.c
> index b0e10c4e..a243fae1 100644
> --- a/arch/riscv/kernel/perf_event.c
> +++ b/arch/riscv/kernel/perf_event.c
> @@ -27,7 +27,6 @@
>   #include <linux/mutex.h>
>   #include <linux/bitmap.h>
>   #include <linux/irq.h>
> -#include <linux/interrupt.h>
>   #include <linux/perf_event.h>
>   #include <linux/atomic.h>
>   #include <linux/of.h>
> 
ping ?

Regards,
Atish