linux-kernel - [PATCH] block: fix noderef.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 14 Aug 2018 07:59:47 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Bart Van Assche <bart.vanassche@....com>
Cc:     kbuild-all@...org, Jens Axboe <axboe@...nel.dk>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] block: fix noderef.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>

block/genhd.c:1483:37-43: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: b4032d402850 ("block: Introduce alloc_disk_node_attr()")
Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
---

 genhd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1480,7 +1480,7 @@ struct gendisk *__alloc_disk_node(int mi
 		disk_to_dev(disk)->class = &block_class;
 		disk_to_dev(disk)->type = &disk_type;
 		if (num_groups) {
-			memcpy(disk->ag, ag, num_groups * sizeof(ag));
+			memcpy(disk->ag, ag, num_groups * sizeof(*ag));
 			disk_to_dev(disk)->groups = disk->ag;
 		}
 		device_initialize(disk_to_dev(disk));