linux-kernel - Re: [PATCHv3 0/3] change some function to be void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Aug 2018 14:53:40 +0200
From:   David Sterba <dsterba@...e.cz>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     clm@...com, jbacik@...com, dsterba@...e.com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 0/3] change some function to be void function

On Wed, Aug 08, 2018 at 09:47:52PM +0800, zhong jiang wrote:
> v3->v2:
>  - Repost the patches with detailed changelog.
> v1->v2:
>  - Fix v1 issue that forget to return after remove the variable "ret".
> 
> zhong jiang (3):
>   fs/btrfs/disk-io: change btrfs_destroy_delayed_refs to be void
>     function
>   fs/btrfs/extent-tree: change btrfs_free_reserved_bytes to be void
>     funtion
>   fs/btrfs/tree-log: change btrfs_pin_log_trans to be void function

The patches 2 and 3 can be applied, but please update che subject and
put just "btrfs: " there, not the full file path. That we can find in
the diff. The changelogs can be still improved to be clear about callers
vs callees. Please update and resend.