linux-kernel - [PATCH] fscache: don't duplicate seq_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 16 Aug 2018 15:37:31 +0200
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     David Howells <dhowells@...hat.com>
Cc:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        linux-cachefs@...hat.com, linux-kernel@...r.kernel.org
Subject: [PATCH] fscache: don't duplicate seq_release_private

Replace fscache_objlist_release by the completely equivalent
seq_release_private.

Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
---
 fs/fscache/object-list.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c
index 43e6e28c164f..3e1c97d34e25 100644
--- a/fs/fscache/object-list.c
+++ b/fs/fscache/object-list.c
@@ -397,21 +397,9 @@ static int fscache_objlist_open(struct inode *inode, struct file *file)
 	return 0;
 }
 
-/*
- * clean up on close
- */
-static int fscache_objlist_release(struct inode *inode, struct file *file)
-{
-	struct seq_file *m = file->private_data;
-
-	kfree(m->private);
-	m->private = NULL;
-	return seq_release(inode, file);
-}
-
 const struct file_operations fscache_objlist_fops = {
 	.open		= fscache_objlist_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
-	.release	= fscache_objlist_release,
+	.release	= seq_release_private,
 };
-- 
2.16.4