linux-kernel - Re: [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Aug 2018 16:40:39 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Heiko Stuebner <heiko@...ech.de>, thierry.reding@...il.com
Cc:     hl@...k-chips.com, briannorris@...omium.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        nickey.yang@...k-chips.com, seanpaul@...omium.org
Subject: Re: [PATCH] drm/panel: p079zca: unconditionally remove the panel on
 removal

On Thu, 2018-08-16 at 16:09 +0200, Heiko Stuebner wrote:
> There is no need to check innolux->base.dev when trying to remove
> the panel, as that variable is always set directly before the panel
> gets added and will still be available on panel_remove.
> 
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
>  drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index 72edb334d997..ca4ae45dd307 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -506,8 +506,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
>  
>  static void innolux_panel_del(struct innolux_panel *innolux)
>  {
> -	if (innolux->base.dev)
> -		drm_panel_remove(&innolux->base);
> +	drm_panel_remove(&innolux->base);
>  }
>  
>  static int innolux_panel_probe(struct mipi_dsi_device *dsi)

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp