linux-kernel - Re: [PATCH] platform/x86: fix intel_punit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 14:00:02 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Arnd Bergmann <arnd.bergmann@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Zha Qipeng <qipeng.zha@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH] platform/x86: fix intel_punit_ipc.c build errors

On Wed, Aug 15, 2018 at 7:12 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build errors by #including <linux/io.h>.
>
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
> ../drivers/platform/x86/intel_punit_ipc.c:55:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>   return readl(ipcdev->base[type][BASE_IFACE]);
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_write_cmd':
> ../drivers/platform/x86/intel_punit_ipc.c:60:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
>   writel(cmd, ipcdev->base[type][BASE_IFACE]);
>

Thanks, pushed to our for-next queue, with Fixes tag appended.

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Zha Qipeng <qipeng.zha@...el.com>
> Cc: platform-driver-x86@...r.kernel.org
> ---
> Found in linux-next but applies to current mainline also.
>
>  drivers/platform/x86/intel_punit_ipc.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20180815.orig/drivers/platform/x86/intel_punit_ipc.c
> +++ linux-next-20180815/drivers/platform/x86/intel_punit_ipc.c
> @@ -18,6 +18,7 @@
>  #include <linux/bitops.h>
>  #include <linux/device.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/platform_device.h>
>  #include <asm/intel_punit_ipc.h>
>
>
>



-- 
With Best Regards,
Andy Shevchenko