linux-kernel - Re: [PATCH] media: camss: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 14:32:25 +0300
From:   Todor Tomov <todor.tomov@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Hans Verkuil <hansverk@...co.com>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: camss: mark PM functions as __maybe_unused

Thank you Arnd.

On 17.08.2018 12:53, Arnd Bergmann wrote:
> The empty suspend/resume functions cause a build warning
> when they are unused:
> 
> drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]
> 
> Mark them as __maybe_unused so the compiler can silently drop them.
> 
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Todor Tomov <todor.tomov@...aro.org>

> ---
>  drivers/media/platform/qcom/camss/camss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index dcc0c30ef1b1..9f19d5f5966b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -993,12 +993,12 @@ static const struct of_device_id camss_dt_match[] = {
>  
>  MODULE_DEVICE_TABLE(of, camss_dt_match);
>  
> -static int camss_runtime_suspend(struct device *dev)
> +static int __maybe_unused camss_runtime_suspend(struct device *dev)
>  {
>  	return 0;
>  }
>  
> -static int camss_runtime_resume(struct device *dev)
> +static int __maybe_unused camss_runtime_resume(struct device *dev)
>  {
>  	return 0;
>  }
> 

-- 
Best regards,
Todor Tomov