linux-kernel - Re: [PATCH resend] irqchip/tango: Set irq handler and data in one go

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 14:45:49 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Jason Cooper <jason@...edaemon.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] irqchip/tango: Set irq handler and data in one go

On 17/08/18 13:10, Martin Kaiser wrote:
> Replace the two separate calls for setting the irq handler and data with
> a single irq_set_chained_handler_and_data() call.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
> Resending this, it seems this got lost along the way. Not a major change,
> of course. But should also be simple to review.
> 
> Thanks & Best regards,
> Martin
> 
>  drivers/irqchip/irq-tango.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c
> index 0c085303a583..580e2d72b9ba 100644
> --- a/drivers/irqchip/irq-tango.c
> +++ b/drivers/irqchip/irq-tango.c
> @@ -205,8 +205,7 @@ static int __init tangox_irq_init(void __iomem *base, struct resource *baseres,
>  
>  	tangox_irq_domain_init(dom);
>  
> -	irq_set_chained_handler(irq, tangox_irq_handler);
> -	irq_set_handler_data(irq, dom);
> +	irq_set_chained_handler_and_data(irq, tangox_irq_handler, dom);
>  
>  	return 0;
>  }
> 

Queued, thanks.

	M.
-- 
Jazz is not dead. It just smells funny...