linux-kernel - Re: [PATCH v12 14/14] cpufreq: qcom: Add support for krait based socs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 09:09:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sricharan R <sricharan@...eaurora.org>
Cc:     mark.rutland@....com, robh@...nel.org, sudeep.holla@....com,
        linux@....linux.org.uk, ctatlor97@...il.com, rjw@...ysocki.net,
        viresh.kumar@...aro.org, mturquette@...libre.com,
        linux-pm@...r.kernel.org, sboyd@...eaurora.org,
        linux@...linux.org.uk, thierry.escande@...aro.org,
        linux-kernel@...r.kernel.org, david.brown@...aro.org,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        andy.gross@...aro.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        niklas.cassel@...aro.org, sricharan@...eaurora.org
Subject: Re: [PATCH v12 14/14] cpufreq: qcom: Add support for krait based socs

Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.

On Tue, 14 Aug 2018 17:42:33 +0530, Sricharan R wrote:
> In Certain QCOM SoCs like ipq8064, apq8064, msm8960, msm8974
> that has KRAIT processors the voltage/current value of each OPP
> varies based on the silicon variant in use.
> 
> The required OPP related data is determined based on
> the efuse value. This is similar to the existing code for
> kryo cores. So adding support for krait cores here.
> 
> Signed-off-by: Sricharan R <sricharan@...eaurora.org>

The preferred subject prefix is "dt-bindings: <binding dir>: ...".

> ---
>  .../devicetree/bindings/opp/qcom-nvmem-cpufreq.txt |   3 +-
>  drivers/cpufreq/Kconfig.arm                        |   2 +-
>  drivers/cpufreq/cpufreq-dt-platdev.c               |   5 +
>  drivers/cpufreq/qcom-cpufreq-nvmem.c               | 151 +++++++++++++++++++--
>  4 files changed, 149 insertions(+), 12 deletions(-)
> 

DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.