linux-kernel - Re: [PATCH] kernel: Add spaces around '=' operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 18:19:31 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bhaskar Singh <bhaskar.kernel@...il.com>
Cc:     mark.rutland@....com, linux-kernel@...r.kernel.org,
        mingo@...nel.org
Subject: Re: [PATCH] kernel: Add spaces around '=' operator

On Fri, Aug 17, 2018 at 06:53:48PM +0530, Bhaskar Singh wrote:
> This patch fixes the checkpatch.pl ERROR:
> 
> ERROR: spaces required around that '==' (ctx:VxV)
> 
> Signed-off-by: Bhaskar Singh <bhaskar.kernel@...il.com>
> ---
>  kernel/acct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/acct.c b/kernel/acct.c
> index addf7732fb56..6dc0a55b575c 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -449,7 +449,7 @@ static void fill_ac(acct_t *ac)
>  #endif
>  	do_div(elapsed, AHZ);
>  	ac->ac_btime = get_seconds() - elapsed;
> -#if ACCT_VERSION==2
> +#if ACCT_VERSION == 2

checkpatch is a guide, not a fast rule, and might not matter here.

Please stick to checkpatch fixes in drivers/staging/ only, not any other
part of the kernel unless you know the maintainer accepts such patches.

thanks,

greg k-h