linux-kernel - Re: [PATCH v4 2/2] leds: lm3697: Introduce the lm3697 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 21:37:08 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Dan Murphy <dmurphy@...com>, robh+dt@...nel.org, pavel@....cz
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 2/2] leds: lm3697: Introduce the lm3697 driver

Dan,

On 08/16/2018 10:44 PM, Dan Murphy wrote:
> Jacek
> 
> On 08/16/2018 02:58 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> Thank you for the patch.
>>
>> I didn't review DT parsing details in v3, but now I've produced
>> diff between v3 and v4 to check what has changed.
>>
>> I'm quite surprised realizing that you're not validating
>> HVLED and control banks assignment, having in mind earlier
>> discussions and your concerns about numerous DT configurations
>> to check.
>>
>> Is it on purpose?
>>
> 
> Yes.  It was on purpose.  After sleeping on it and going through the overall
> control to HVLED assignments I realized the user will know quite quickly
> that their configuration is messed up.
> 
> The suggestions actually simplified the code quite nicely which I am happier to have

Ack. Thanks for the v5 - I'll let it sit on the lists for a week anyway,
until the merge window gets closed.

-- 
Best regards,
Jacek Anaszewski