linux-kernel - Re: [PATCH 2/2] drm/amd/display: Don't build DCN1 when kcov is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Aug 2018 09:25:36 +0200
From:   Michel Dänzer <michel@...nzer.net>
To:     sunpeng.li@....com, alexander.deucher@....com,
        christian.koenig@....com, arnd@...db.de
Cc:     airlied@...ux.ie, Jordan.Lazare@....com,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        harry.wentland@....com
Subject: Re: [PATCH 2/2] drm/amd/display: Don't build DCN1 when kcov is
 enabled

On 2018-08-16 09:44 PM, sunpeng.li@....com wrote:
> From: "Leo (Sunpeng) Li" <sunpeng.li@....com>
> 
> DCN1 contains code that utilizes fp math. When
> CONFIG_KCOV_INSTRUMENT_ALL and CONFIG_KCOV_ENABLE_COMPARISONS are
> enabled, build errors are found. See this earlier patch for details:
> 
> https://lists.freedesktop.org/archives/dri-devel/2018-August/186131.html
> 
> As a short term solution, disable CONFIG_DRM_AMD_DC_DCN1_0 when
> KCOV_INSTRUMENT_ALL and KCOV_ENABLE_COMPARISONS are enabled. In
> addition, make it a fully derived config, taking into account
> CONFIG_X86.
> 
> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@....com>
> ---
>  drivers/gpu/drm/amd/display/Kconfig | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
> index 4c35625..ed654a7 100644
> --- a/drivers/gpu/drm/amd/display/Kconfig
> +++ b/drivers/gpu/drm/amd/display/Kconfig
> @@ -4,18 +4,16 @@ menu "Display Engine Configuration"
>  config DRM_AMD_DC
>  	bool "AMD DC - Enable new display engine"
>  	default y
> +	select DRM_AMD_DC_DCN1_0 if X86 && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS)
>  	help
>  	  Choose this option if you want to use the new display engine
>  	  support for AMDGPU. This adds required support for Vega and
>  	  Raven ASICs.
>  
>  config DRM_AMD_DC_DCN1_0
> -	bool "DCN 1.0 Raven family"
> -	depends on DRM_AMD_DC && X86
> -	default y
> +	def_bool n
>  	help
> -	  Choose this option if you want to have
> -	  RV family for display engine
> +	  RV family support for display engine
>  
>  config DEBUG_KERNEL_DC
>  	bool "Enable kgdb break in DC"
> 

Thanks Leo, Alex, Arnd et al for taking care of this! Apologies for the
trouble caused by my change, and for not helping much with the solution
(I was on vacation).

This series is

Reviewed-by: Michel Dänzer <michel.daenzer@....com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer