linux-kernel - [PATCH v2 6/8] dlm: use seq_open_data in table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Aug 2018 15:24:32 +0200
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     cluster-devel@...hat.com
Cc:     linux-kernel@...r.kernel.org,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: [PATCH v2 6/8] dlm: use seq_open_data in table_openN functions

Using the seq_open_data helper simplifies these to oneliners.

Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
---
Depends on 1/8 introducing seq_open_data.

fs/dlm/debug_fs.c | 44 ++++----------------------------------------
 1 file changed, 4 insertions(+), 40 deletions(-)

diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c
index fa08448e35dd..02892bca05b4 100644
--- a/fs/dlm/debug_fs.c
+++ b/fs/dlm/debug_fs.c
@@ -608,58 +608,22 @@ static const struct file_operations format4_fops;
 
 static int table_open1(struct inode *inode, struct file *file)
 {
-	struct seq_file *seq;
-	int ret;
-
-	ret = seq_open(file, &format1_seq_ops);
-	if (ret)
-		return ret;
-
-	seq = file->private_data;
-	seq->private = inode->i_private; /* the dlm_ls */
-	return 0;
+	return seq_open_data(file, &format1_seq_ops, inode->i_private);
 }
 
 static int table_open2(struct inode *inode, struct file *file)
 {
-	struct seq_file *seq;
-	int ret;
-
-	ret = seq_open(file, &format2_seq_ops);
-	if (ret)
-		return ret;
-
-	seq = file->private_data;
-	seq->private = inode->i_private; /* the dlm_ls */
-	return 0;
+	return seq_open_data(file, &format2_seq_ops, inode->i_private);
 }
 
 static int table_open3(struct inode *inode, struct file *file)
 {
-	struct seq_file *seq;
-	int ret;
-
-	ret = seq_open(file, &format3_seq_ops);
-	if (ret)
-		return ret;
-
-	seq = file->private_data;
-	seq->private = inode->i_private; /* the dlm_ls */
-	return 0;
+	return seq_open_data(file, &format3_seq_ops, inode->i_private);
 }
 
 static int table_open4(struct inode *inode, struct file *file)
 {
-	struct seq_file *seq;
-	int ret;
-
-	ret = seq_open(file, &format4_seq_ops);
-	if (ret)
-		return ret;
-
-	seq = file->private_data;
-	seq->private = inode->i_private; /* the dlm_ls */
-	return 0;
+	return seq_open_data(file, &format4_seq_ops, inode->i_private);
 }
 
 static const struct file_operations format1_fops = {
-- 
2.16.4