linux-kernel - [PATCH] acpi: remove a meaningless null check before debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Aug 2018 18:49:20 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <rjw@...ysocki.net>, <lenb@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>
Subject: [PATCH] acpi: remove a meaningless null check before debugfs_remove

debugfs_remove has taken null pointer into account. So it is safe
to remove the check before debugfs_remove.

Signed-off-by: zhong jiang <zhongjiang@...wei.com>
---
 drivers/acpi/custom_method.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
index e967c11..4451877 100644
--- a/drivers/acpi/custom_method.c
+++ b/drivers/acpi/custom_method.c
@@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
 
 static void __exit acpi_custom_method_exit(void)
 {
-	if (cm_dentry)
-		debugfs_remove(cm_dentry);
+	debugfs_remove(cm_dentry);
 }
 
 module_init(acpi_custom_method_init);
-- 
1.7.12.4