linux-kernel - Re: [PATCH] iio: adc: qcom-spmi-adc5: Verify channel numbers from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Sep 2018 18:52:28 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Siddartha Mohanadoss <smohanad@...eaurora.org>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] iio: adc: qcom-spmi-adc5: Verify channel numbers from
 DT

On Mon, 27 Aug 2018 14:14:53 -0700
Matthias Kaehlcke <mka@...omium.org> wrote:

> The driver only defines a subset of all possible ADC channels. Channel
> numbers read from the device tree are accepted as long as they don't
> exceed a max value, even when no channel definition exists. Add a
> check to abort initialization in this case.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks for tidying this up.

Jonathan

> ---
>  drivers/iio/adc/qcom-spmi-adc5.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> index 9c8e6f9e8248..ab5bec917c0a 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -519,7 +519,8 @@ static int adc5_get_dt_channel_data(struct adc5_chip *adc,
>  		return ret;
>  	}
>  
> -	if (chan > ADC5_PARALLEL_ISENSE_VBAT_IDATA) {
> +	if (chan > ADC5_PARALLEL_ISENSE_VBAT_IDATA ||
> +	    !data->adc_chans[chan].datasheet_name) {
>  		dev_err(dev, "%s invalid channel number %d\n", name, chan);
>  		return -EINVAL;
>  	}