linux-kernel - Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Sep 2018 08:35:09 -0500
From:   "Andrew F. Davis" <afd@...com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        NXP Linux Team <linux-imx@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin

On 09/02/2018 11:54 PM, Shawn Guo wrote:
> On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote:
>> The correct DT property for specifying a GPIO used for reset
>> is "reset-gpios", fix this here.
>>
>> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
> 
> This Fixes tag and word 'Fix' in subject is inappropriate to me, as you
> are not fixing something wrong from the beginning, but actually
> replacing a deprecated property with new one.
> 


reset-gpios was standard before this driver got it backwards, but it
also wasn't required to be one way or the other as far as I can tell, so
I can see your point that this isn't technically "broken". I have no
preference, so I'll change the subject and drop the fixes for v2.

Andrew


> Shawn
> 
>>
>> Signed-off-by: Andrew F. Davis <afd@...com>
>> ---
>>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 7fff3717cf7c..a0f5cfda0055 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -384,7 +384,7 @@
>>  		AVDD-supply = <&reg_3p3v>;
>>  		IOVDD-supply = <&reg_3p3v>;
>>  		DVDD-supply = <&vgen4_reg>;
>> -		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>> +		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
>>  	};
>>  
>>  	accel@1c {
>> @@ -572,7 +572,7 @@
>>  		AVDD-supply = <&reg_3p3v>;
>>  		IOVDD-supply = <&reg_3p3v>;
>>  		DVDD-supply = <&vgen4_reg>;
>> -		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
>> +		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
>>  	};
>>  
>>  	touchscreen@20 {
>> -- 
>> 2.18.0
>>