linux-kernel - Re: [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Sep 2018 16:34:36 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR

On 4 September 2018 at 04:59, YueHaibing <yuehaibing@...wei.com> wrote:
> Fix inconsistent IS_ERR and PTR_ERR in tegra_sdhci_init_pinctrl_info,
> the proper pointer to be passed as argument is 'pinctrl_state_1v8'
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index e80716c..c789158 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
>                 pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
>         if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
>                 dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
> -                        PTR_ERR(tegra_host->pinctrl_state_3v3));
> +                        PTR_ERR(tegra_host->pinctrl_state_1v8));
>                 return -1;
>         }
>
> --
> 2.7.0
>
>