linux-kernel - Re: [PATCH] infiniband: nes: add unlikely() to assert()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Sep 2018 09:01:06 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Igor Stoppa <igor.stoppa@...il.com>
Cc:     Faisal Latif <faisal.latif@...el.com>,
        Igor Stoppa <igor.stoppa@...wei.com>,
        Chien Tung <chien.tin.tung@...el.com>,
        Roland Dreier <rolandd@...co.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: nes: add unlikely() to assert()

On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote:
> Typically the assert is expected to not fail.

This whole assert can be removed.

>
> Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com>
> Acked-by: Doug Ledford <dledford@...hat.com>

Most probably that I missed discussion, but anyway, does this
"Acked-by" come from internal or external discussion?

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)