linux-kernel - Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Sep 2018 12:21:00 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Dave Hansen <dave.hansen@...el.com>,
        sean.j.christopherson@...el.com, nhorman@...hat.com,
        npmccallum@...hat.com, linux-sgx@...r.kernel.org,
        serge.ayoun@...el.com, shay.katz-zamir@...el.com,
        suresh.b.siddha@...el.com, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Biggers <ebiggers@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

On Wed, Sep 05, 2018 at 08:36:54PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 5, 2018 at 8:34 PM Jarkko Sakkinen
> <jarkko.sakkinen@...ux.intel.com> wrote:
> > On Tue, Sep 04, 2018 at 08:59:58PM +0300, Andy Shevchenko wrote:
> > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen
> > > <jarkko.sakkinen@...ux.intel.com> wrote:
> 
> > Thanks, very detailed! Does not make sense to ack these separately so I
> > just say that I try to fix them all with care.
> 
> Just comment on which you disagree.
> I think one of them is the header file location. It seems I missed
> it's current place.
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Ah, right, sorry forgot to comment it in LKML.

There is another open. If I grep through the kernel tree I see SPDX
headers that are decorated both with C99- and C89-style comments. I
guess I ended up using C99-style because when I was instructed to add
SPDX headers in the first place that was the example I was given. Still
checkpatch.pl complains about C99-style comments.

Which one is right and why the kernel tree is polluted with C99-headers
when they do not pass checkpatch.pl? How those commits were ever
accepted?

/Jarkko