linux-kernel - Re: [GIT PULL] Staging/IIO driver patches for 4.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Sep 2018 10:16:26 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Ahmed S. Darwish" <darwish.07@...il.com>
Cc:     Simon Que <sque@...omium.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        John Joseph <jnjoseph@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Rob Springer <rspringer@...gle.com>,
        devel@...uxdriverproject.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Todd Poynor <toddpoynor@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [GIT PULL] Staging/IIO driver patches for 4.19-rc1

On Tue, Aug 28, 2018 at 02:30:49PM +0000, Ahmed S. Darwish wrote:
> Hi!
> 
> On Tue, Aug 28, 2018 at 02:36:07PM +0200, Greg KH wrote:
> > On Tue, Aug 28, 2018 at 10:38:17AM +0000, Ahmed S. Darwish wrote:
> > > [ re-send; forgotten lkml CC added; sorry ]
> > >
> > > Hi,
> > >
> > > On Sat, 18 Aug 2018 17:57:24 +0200, Greg KH wrote:
> > > [...]
> > > > addition of some new IIO drivers.  Also added was a "gasket" driver from
> > > > Google that needs loads of work and the erofs filesystem.
> > > >
> > >
> > > Why are we adding __a whole new in-kernel framework__ for
> > > developing basic user-space drivers?
> > >
> > > We already have a frameowrk for that, and it's UIO. [1] The UIO
> > > code is a very stable and simple subsystem; it's also heavily used
> > > in the embedded industry..
> >
> > As Todd said, the code will end up being a simple UIO driver, if even
> > that big, in th end.  It is just going to take him a while to constantly
> > refactor things until he achieves that goal...
> >
> > > I've looked at the gasket documentation [2], and the first user
> > > of this new in-kernel API [3], and this is almost replicating UIO
> > > it's not funny. [4] True, the gasket APIs adds some extra new
> > > conveniences (PCI BAR re-mapping, MSI, ..), but there's no
> > > technical reason this cannot be added to the UIO code instead.
> >
> > {shh} That's my plan :)
> >
> 
> Cool, thanks a lot.
> 
> Can we then merge something like below patch?
> 
> [ I've searched the gasket included TODO file before posting,
>   but did not find any mention of UIO. Below patch will make
>   sure this will not be forgotten over time.. ]

Looks good, can you resend it in a format I can apply it in (i.e. one
that does not require me to hand-edit a patch?)

thanks,

greg k-h