| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Sep 2018 13:37:19 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Tony Xie <tony.xie@...k-chips.com>
Cc: heiko@...ech.de, broonie@...nel.org, robh+dt@...nel.org,
mark.rutland@....com, a.zummo@...ertech.it,
alexandre.belloni@...tlin.com, sboyd@...nel.org,
linux-clk@...r.kernel.org, linux-rtc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, chenjh@...k-chips.com,
xsf@...k-chips.com, zhangqing@...k-chips.com,
huangtao@...k-chips.com
Subject: Re: [PATCH v3 3/5] dt-bindings: mfd: rk808: Add binding information
for RK809 and RK817.
On Fri, 24 Aug 2018, Tony Xie wrote:
> Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC.
>
> Signed-off-by: Tony Xie <tony.xie@...k-chips.com>
> ---
> Documentation/devicetree/bindings/mfd/rk808.txt | 56 +++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
> index 91b6522..c025a99 100644
> --- a/Documentation/devicetree/bindings/mfd/rk808.txt
> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
> @@ -3,11 +3,15 @@ RK8XX Power Management Integrated Circuit
> The rk8xx family current members:
> rk805
> rk808
> +rk809
> +rk817
> rk818
>
> Required properties:
> - compatible: "rockchip,rk805"
> - compatible: "rockchip,rk808"
> +- compatible: "rockchip,rk809"
> +- compatible: "rockchip,rk817"
> - compatible: "rockchip,rk818"
> - reg: I2C slave address
> - interrupt-parent: The parent interrupt controller.
> @@ -46,6 +50,28 @@ Optional RK808 properties:
> the gpio controller. If DVS GPIOs aren't present, voltage changes will happen
> very quickly with no slow ramp time.
>
> +Optional RK809 properties:
> +- vcc1-supply: The input supply for DCDC_REG1
> +- vcc2-supply: The input supply for DCDC_REG2
> +- vcc3-supply: The input supply for DCDC_REG3
> +- vcc4-supply: The input supply for DCDC_REG4
> +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3
> +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6
> +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9
> +- vcc8-supply: The input supply for SWITCH_REG1
> +- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2
> +
> +Optional RK817 properties:
> +- vcc1-supply: The input supply for DCDC_REG1
> +- vcc2-supply: The input supply for DCDC_REG2
> +- vcc3-supply: The input supply for DCDC_REG3
> +- vcc4-supply: The input supply for DCDC_REG4
> +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3
> +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6
> +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9
> +- vcc8-supply: The input supply for BOOST
> +- vcc9-supply: The input supply for OTG_SWITCH
I think I'd like to see these squashed down a bit.
Something like:
> +Optional shared RK809 and RK817 properties:
> +- vcc1-supply: The input supply for DCDC_REG1
> +- vcc2-supply: The input supply for DCDC_REG2
> +- vcc3-supply: The input supply for DCDC_REG3
> +- vcc4-supply: The input supply for DCDC_REG4
> +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3
> +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6
> +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9
> +
> +Optional RK809 properties:
> +- vcc8-supply: The input supply for SWITCH_REG1
> +- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2
> +
> +Optional RK817 properties:
> +- vcc8-supply: The input supply for BOOST
> +- vcc9-supply: The input supply for OTG_SWITCH
That's if 1-7 are as identical as they look at first glance.
> Optional RK818 properties:
> - vcc1-supply: The input supply for DCDC_REG1
> - vcc2-supply: The input supply for DCDC_REG2
> @@ -87,6 +113,28 @@ number as described in RK808 datasheet.
> - SWITCH_REGn
> - valid values for n are 1 to 2
>
> +Following regulators of the RK809 PMIC block are supported. Note that
> +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
> +number as described in RK808 datasheet.
> +
> + - DCDC_REGn
> + - valid values for n are 1 to 5.
> + - LDO_REGn
> + - valid values for n are 1 to 9.
> + - SWITCH_REGn
> + - valid values for n are 1 to 2.
> +
> +Following regulators of the RK817 PMIC block are supported. Note that
> +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
> +number as described in RK818 datasheet.
Is there any need to keep saying the same thing over and over?
Especially for something fairly obvious.
> + - DCDC_REGn
> + - valid values for n are 1 to 4.
> + - LDO_REGn
> + - valid values for n are 1 to 9.
> + - BOOST
> + - OTG_SWITCH
> +
> Following regulators of the RK818 PMIC block are supported. Note that
> the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
> number as described in RK818 datasheet.
> @@ -99,6 +147,14 @@ number as described in RK818 datasheet.
> - HDMI_SWITCH
> - OTG_SWITCH
>
> +There are three pins needed to config for each of RK809 and RK817,
> +named "gpio_ts" "gpio_gt" "gpio_slp".
> + The gpio_gt and gpio_ts pins support the gpio function.
> + The gpio_slp pin is for controlling the pmic states, as below:
> + - reset
> + - power down
> + - sleep
> +
> Standard regulator bindings are used inside regulator subnodes. Check
> Documentation/devicetree/bindings/regulator/regulator.txt
> for more details
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists