linux-kernel - EDAC polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Sep 2018 06:09:01 -0700
From:   Sodagudi Prasad <psodagud@...eaurora.org>
To:     bp@...en8.de, mchehab@...nel.org, linux-edac@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: EDAC polling

Hi All,

While adding edac_device control info using edac_device_add_device(), 
changed the poll_msec at client driver level.
For example -.
https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/edac/qcom_llcc_edac.c?h=msm-4.9#n385

I see that client driver request is not considered and always default 
value(1 second) is considered. During the initialization
edac_device_workq_setup sets poll_msed to 1 second.

int edac_device_add_device(struct edac_device_ctl_info *edac_dev)
{
...
...
         /* If there IS a check routine, then we are running POLLED */
         if (edac_dev->edac_check != NULL) {
                 /* This instance is NOW RUNNING */
                 edac_dev->op_state = OP_RUNNING_POLL;

                 /*
                  * enable workq processing on this instance,
                  * default = 1000 msec
                  */
                 edac_device_workq_setup(edac_dev, 1000);
         } else {
                 edac_dev->op_state = OP_RUNNING_INTERRUPT;
         }

May I know why client edev_ctl->poll_msec settings is not considered?

-Thanks, Prasad

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
Linux Foundation Collaborative Project