linux-kernel - Re: [PATCH] kbuild: remove old check for CFLAGS use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Sep 2018 22:06:54 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: remove old check for CFLAGS use

2018-09-12 15:18 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> This check has been here more than a decade since commit 0c53c8e6eb45
> ("kbuild: check for wrong use of CFLAGS").
>
> Enough time for migration has passed.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---

Applied to linux-kbuild.

>  scripts/Makefile.build | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 5a2d1c9..cb03774 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -36,21 +36,11 @@ subdir-ccflags-y :=
>
>  include scripts/Kbuild.include
>
> -# For backward compatibility check that these variables do not change
> -save-cflags := $(CFLAGS)
> -
>  # The filename Kbuild has precedence over Makefile
>  kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
>  kbuild-file := $(if $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Kbuild,$(kbuild-dir)/Makefile)
>  include $(kbuild-file)
>
> -# If the save-* variables changed error out
> -ifeq ($(KBUILD_NOPEDANTIC),)
> -        ifneq ("$(save-cflags)","$(CFLAGS)")
> -                $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use ccflags-y)
> -        endif
> -endif
> -
>  include scripts/Makefile.lib
>
>  # Do not include host rules unless needed
> --
> 2.7.4
>



-- 
Best Regards
Masahiro Yamada